Messages in this thread | | | Subject | Re: [PATCH next] perf tools: fix potential memleak in perf events parser | From | Chen Wandun <> | Date | Thu, 11 Jun 2020 23:05:07 +0800 |
| |
在 2020/6/11 21:16, Arnaldo Carvalho de Melo 写道: > Em Thu, Jun 11, 2020 at 09:42:34AM +0800, Chen Wandun escreveu: >> Fix potential memory leak in function parse_events_term__sym_hw() >> and parse_events_term__clone(). >> >> 1. Free memory when errors occur. >> 2. Function new_term may return error, so it is need to free memory >> when the return value is negative. > Try to fix one thing per patch, i.e. first the most obvious one, then > the other that requires going thru the new_term() logic, i.e. first > this, which is super easy to review:
> Would you like to add the tag “Fixes” to the commit message? > Hi, Arnaldo and Markus.
Thank you for your reply, I will update in v2
Best Regards,
Chen Wandun
| |