lkml.org 
[lkml]   [2020]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 06/16] mm/thp: clean up lru_add_page_tail
    Date
    Since the first parameter is only used by head page, it's better to make
    it stright.

    Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: linux-mm@kvack.org
    Cc: linux-kernel@vger.kernel.org
    ---
    mm/huge_memory.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    index 09f910bc7429..1cd81a9a4f80 100644
    --- a/mm/huge_memory.c
    +++ b/mm/huge_memory.c
    @@ -2340,19 +2340,19 @@ static void remap_page(struct page *page)
    }
    }

    -void lru_add_page_tail(struct page *page, struct page *page_tail,
    +void lru_add_page_tail(struct page *head, struct page *page_tail,
    struct lruvec *lruvec, struct list_head *list)
    {
    - VM_BUG_ON_PAGE(!PageHead(page), page);
    - VM_BUG_ON_PAGE(PageCompound(page_tail), page);
    - VM_BUG_ON_PAGE(PageLRU(page_tail), page);
    + VM_BUG_ON_PAGE(!PageHead(head), head);
    + VM_BUG_ON_PAGE(PageCompound(page_tail), head);
    + VM_BUG_ON_PAGE(PageLRU(page_tail), head);
    lockdep_assert_held(&lruvec_pgdat(lruvec)->lru_lock);

    if (!list)
    SetPageLRU(page_tail);

    - if (likely(PageLRU(page)))
    - list_add_tail(&page_tail->lru, &page->lru);
    + if (likely(PageLRU(head)))
    + list_add_tail(&page_tail->lru, &head->lru);
    else if (list) {
    /* page reclaim is reclaiming a huge page */
    get_page(page_tail);
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2020-06-11 08:18    [W:4.035 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site