Messages in this thread | | | Subject | Re: [PATCH v2] btrfs: Remove error messages for failed memory allocations | From | Markus Elfring <> | Date | Thu, 11 Jun 2020 16:00:21 +0200 |
| |
> As there is a dump_stack() done on memory allocation > failures, these messages might as well be deleted instead.
* I imagine that an other wording variant can become clearer for the change description.
* I suggest to reconsider the patch subject.
… > +++ b/fs/btrfs/check-integrity.c > @@ -632,7 +632,6 @@ static int btrfsic_process_superblock(struct btrfsic_state *state, > > selected_super = kzalloc(sizeof(*selected_super), GFP_NOFS); > if (NULL == selected_super) { > - pr_info("btrfsic: error, kmalloc failed!\n"); > return -ENOMEM; > }
How do you think about to use the following error handling instead?
if (!selected_super) return -ENOMEM;
Regards, Markus
| |