Messages in this thread | | | Date | Thu, 11 Jun 2020 10:40:38 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 00/10] perf parse-events: enable more flex/bison warnings |
| |
Em Thu, Jun 11, 2020 at 10:38:54AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jun 11, 2020 at 10:07:58AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jun 11, 2020 at 11:02:49AM +0200, Jiri Olsa escreveu: > > > On Wed, Jun 10, 2020 at 02:50:50PM -0700, Ian Rogers wrote: > > > > All C compiler warnings are disabled are disabled by -w. This change > > > > removes the -w from flex and bison targets. To avoid implicit > > > > declarations header files are declared as targets and included. > > > > > > > > Tested with GCC 9.3.0 and clang 9.0.1. > > > > > > > > Previously posted as a single change: > > > > https://lore.kernel.org/lkml/20200609234344.3795-2-irogers@google.com/ > > > > > > > > Ian Rogers (10): > > > > perf parse-events: Use automatic variable for flex input > > > > perf parse-events: Use automatic variable for yacc input > > > > perf pmu: Add bison debug build flag > > > > perf pmu: Add flex debug build flag > > > > perf parse-events: Declare flex header file output > > > > perf parse-events: Declare bison header file output > > > > perf parse-events: Disable a subset of flex warnings > > > > perf expr: Avoid implicit lex function declaration > > > > perf parse-events: Avoid implicit lex function declaration > > > > perf parse-events: Disable a subset of bison warnings > > > > > > looks great, I wonder what the -w replacement will do in > > > Arnaldo's distro test, but it'd be nice to get rid it > > > > > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > > > Thanks, applied locally and will submit it to the test build suite. > > Failed so far for, I'll leave it running, its a holiday here today, so > I'll be on this occasionally, please look until the end of the (long) > message, there are errors for more distros, some are, as expected the > same, but should give a good idea of some extra fixes needed. >
24 debian:9 : FAIL gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, clang version 3.8.1-24 (tags/RELEASE_381/final)
FLEX /tmp/build/perf/util/pmu-flex.c CC /tmp/build/perf/util/pmu-bison.o FLEX /tmp/build/perf/util/expr-flex.c FLEX /tmp/build/perf/util/expr-flex.h CC /tmp/build/perf/util/parse-events.o CC /tmp/build/perf/util/parse-events-flex.o CC /tmp/build/perf/util/pmu.o CC /tmp/build/perf/util/pmu-flex.o /tmp/build/perf/util/parse-events-flex.c: In function 'yy_get_next_buffer': /tmp/build/perf/util/parse-events-flex.c:4717:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for ( n = 0; n < max_size && \ ^ /tmp/build/perf/util/parse-events-flex.c:5656:3: note: in expansion of macro 'YY_INPUT' YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), ^~~~~~~~ /tmp/build/perf/util/pmu-flex.c: In function 'yy_get_next_buffer': /tmp/build/perf/util/pmu-flex.c:608:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for ( n = 0; n < max_size && \ ^ /tmp/build/perf/util/pmu-flex.c:1058:3: note: in expansion of macro 'YY_INPUT' YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), ^~~~~~~~ CC /tmp/build/perf/util/expr-flex.o /tmp/build/perf/util/expr-flex.c: In function 'yy_get_next_buffer': /tmp/build/perf/util/expr-flex.c:711:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] for ( n = 0; n < max_size && \ ^ /tmp/build/perf/util/expr-flex.c:1241:3: note: in expansion of macro 'YY_INPUT' YY_INPUT( (&YY_CURRENT_BUFFER_LVALUE->yy_ch_buf[number_to_move]), ^~~~~~~~ CC /tmp/build/perf/util/expr-bison.o CC /tmp/build/perf/util/expr.o cc1: all warnings being treated as errors mv: cannot stat '/tmp/build/perf/util/.pmu-flex.o.tmp': No such file or directory /git/linux/tools/build/Makefile.build:96: recipe for target '/tmp/build/perf/util/pmu-flex.o' failed make[4]: *** [/tmp/build/perf/util/pmu-flex.o] Error 1 make[4]: *** Waiting for unfinished jobs...
debian:10 is going well so far, some of the builds passed
| |