lkml.org 
[lkml]   [2020]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] platform/x86: intel-hid: Use hp-wireless for rfkill on HP platforms
Date
> > Just having the ACPI device present doesn't actually mean that the user
> > has a kernel compiled with hp-wireless or that it has finished
> initializing.
>
> We can use IS_REACHEABLE() to see if it's compiled.

Yes that was going to be my first suggestion.

>
> >
> > I would think this needs a better handshake in case hp-wireless was
> unloaded
> > or not present so the event could still come through intel-hid in this
> > circumstance.
>
> However, it's hard to determine if the other driver has finished
> initialization or any form of cross module handshake.
> Can you please point me to any good example if there's one?

Take a look at how drivers that use dell-wmi-descriptor work. They can rely
upon looking at -EPROBE_DEFER return code when trying to access the functionality
and do a handoff.

>
> >
> >> +
> >> return AE_OK;
> >> }
> >>
> >> --
> >> 2.17.1

\
 
 \ /
  Last update: 2020-06-11 15:16    [W:0.066 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site