lkml.org 
[lkml]   [2020]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 03/16] mm/compaction: correct the comments of compact_defer_shift
    Date
    There is no compact_defer_limit. It should be compact_defer_shift in
    use. and add compact_order_failed explanation.

    Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: linux-mm@kvack.org
    Cc: linux-kernel@vger.kernel.org
    ---
    include/linux/mmzone.h | 1 +
    mm/compaction.c | 2 +-
    2 files changed, 2 insertions(+), 1 deletion(-)

    diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
    index df1f08486d81..7ae464188588 100644
    --- a/include/linux/mmzone.h
    +++ b/include/linux/mmzone.h
    @@ -512,6 +512,7 @@ struct zone {
    * On compaction failure, 1<<compact_defer_shift compactions
    * are skipped before trying again. The number attempted since
    * last failure is tracked with compact_considered.
    + * compact_order_failed is the minimum compaction failed order.
    */
    unsigned int compact_considered;
    unsigned int compact_defer_shift;
    diff --git a/mm/compaction.c b/mm/compaction.c
    index fd988b7e5f2b..48114f98e362 100644
    --- a/mm/compaction.c
    +++ b/mm/compaction.c
    @@ -136,7 +136,7 @@ void __ClearPageMovable(struct page *page)

    /*
    * Compaction is deferred when compaction fails to result in a page
    - * allocation success. 1 << compact_defer_limit compactions are skipped up
    + * allocation success. compact_defer_shift++, compactions are skipped up
    * to a limit of 1 << COMPACT_MAX_DEFER_SHIFT
    */
    void defer_compaction(struct zone *zone, int order)
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2020-06-11 08:18    [W:3.679 / U:0.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site