Messages in this thread | | | Subject | Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Check the regmap return value when setting a GPIO | From | Stephen Boyd <> | Date | Thu, 11 Jun 2020 02:58:24 -0700 |
| |
Quoting Douglas Anderson (2020-06-08 10:48:35) > The ti_sn_bridge_gpio_set() got the return value of > regmap_update_bits() but didn't check it. The function can't return > an error value, but we should at least print a warning if it didn't > work. > > This fixes a compiler warning about setting "ret" but not using it. > > Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 1080e4f9df96..526add27dc03 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -999,6 +999,9 @@ static void ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset, > ret = regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG, > BIT(SN_GPIO_OUTPUT_SHIFT + offset), > val << (SN_GPIO_OUTPUT_SHIFT + offset)); > + if (ret) > + dev_warn(pdata->dev, > + "Failed to set bridge GPIO %d: %d\n", offset, ret);
GPIO %u because it's unsigned?
| |