lkml.org 
[lkml]   [2020]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 25/27] clk: bcm2835: Allow custom CCF flags for the PLLs
From
Date
Hi Maxime,

On Thu, 2020-06-11 at 09:32 +0200, Maxime Ripard wrote:
> While some clock types allow for each clock to specify its own custom
> flags, the PLLs can't. We will need this for the PLLB, so let's add it.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> drivers/clk/bcm/clk-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
> index 32f5c13be9d1..846ea68b2c73 100644
> --- a/drivers/clk/bcm/clk-bcm2835.c
> +++ b/drivers/clk/bcm/clk-bcm2835.c
> @@ -421,6 +421,7 @@ struct bcm2835_pll_data {
> u32 reference_enable_mask;
> /* Bit in CM_LOCK to indicate when the PLL has locked. */
> u32 lock_mask;
> + u32 flags;
>
> const struct bcm2835_pll_ana_bits *ana;
>
> @@ -1310,7 +1311,7 @@ static struct clk_hw *bcm2835_register_pll(struct
> bcm2835_cprman *cprman,
> init.num_parents = 1;
> init.name = pll_data->name;
> init.ops = &bcm2835_pll_clk_ops;
> - init.flags = CLK_IGNORE_UNUSED;
> + init.flags = data->flags | CLK_IGNORE_UNUSED;

This should be 'pll_data->flags'.

With that fixed:

Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

Regards,
Nicolas

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-06-11 11:12    [W:0.101 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site