Messages in this thread | | | From | Daniel Stone <> | Date | Thu, 11 Jun 2020 10:01:46 +0100 | Subject | Re: [Intel-gfx] [PATCH 03/18] dma-fence: basic lockdep annotations |
| |
Hi,
On Thu, 11 Jun 2020 at 09:44, Dave Airlie <airlied@gmail.com> wrote: > On Thu, 11 Jun 2020 at 18:01, Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Introducing a global lockmap that cannot capture the rules correctly, > > Can you document the rules all drivers should be following then, > because from here it looks to get refactored every version of i915, > and it would be nice if we could all aim for the same set of things > roughly. We've already had enough problems with amdgpu vs i915 vs > everyone else with fences, if this stops that in the future then I'd > rather we have that than just some unwritten rules per driver and > untestable.
As someone who has sunk a bunch of work into explicit-fencing awareness in my compositor so I can never be blocked, I'd be disappointed if the infrastructure was ultimately pointless because the documented fencing rules were \_o_/ or thereabouts. Lockdep definitely isn't my area of expertise so I can't comment on the patch per se, but having something to ensure we don't hit deadlocks sure seems a lot better than nothing.
Cheers, Daniel
| |