Messages in this thread | | | Date | Thu, 11 Jun 2020 11:02:49 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 00/10] perf parse-events: enable more flex/bison warnings |
| |
On Wed, Jun 10, 2020 at 02:50:50PM -0700, Ian Rogers wrote: > All C compiler warnings are disabled are disabled by -w. This change > removes the -w from flex and bison targets. To avoid implicit > declarations header files are declared as targets and included. > > Tested with GCC 9.3.0 and clang 9.0.1. > > Previously posted as a single change: > https://lore.kernel.org/lkml/20200609234344.3795-2-irogers@google.com/ > > Ian Rogers (10): > perf parse-events: Use automatic variable for flex input > perf parse-events: Use automatic variable for yacc input > perf pmu: Add bison debug build flag > perf pmu: Add flex debug build flag > perf parse-events: Declare flex header file output > perf parse-events: Declare bison header file output > perf parse-events: Disable a subset of flex warnings > perf expr: Avoid implicit lex function declaration > perf parse-events: Avoid implicit lex function declaration > perf parse-events: Disable a subset of bison warnings
looks great, I wonder what the -w replacement will do in Arnaldo's distro test, but it'd be nice to get rid it
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks, jirka
> > tools/perf/util/Build | 50 +++++++++++++++++++++------------- > tools/perf/util/expr.y | 2 ++ > tools/perf/util/parse-events.y | 1 + > 3 files changed, 34 insertions(+), 19 deletions(-) > > -- > 2.27.0.278.ge193c7cf3a9-goog >
| |