lkml.org 
[lkml]   [2020]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH 1/2] dmaengine: fsl-edma: Add lockdep assert for exported function
Date
On 2020/06/11 20:18 Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Add lockdep assert for an exported function expected to be called under spin
> lock. Since this function is called in different modules, the lockdep assert will
> be self-documenting note about need for locking.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/dma/fsl-edma-common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/fsl-edma-common.c
> b/drivers/dma/fsl-edma-common.c index 5697c3622699..4550818cca4a
> 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -589,6 +589,8 @@ void fsl_edma_xfer_desc(struct fsl_edma_chan
> *fsl_chan) {
> struct virt_dma_desc *vdesc;
>
> + lockdep_assert_held(&fsl_chan->vchan.lock);
> +
> vdesc = vchan_next_desc(&fsl_chan->vchan);
> if (!vdesc)
> return;
> --
> 2.7.4

\
 
 \ /
  Last update: 2020-06-12 04:25    [W:0.148 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site