lkml.org 
[lkml]   [2020]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 46/51] mm: Add DEFINE_READAHEAD
    Date
    From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

    Allow for a more concise definition of a struct readahead_control.

    Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    ---
    include/linux/pagemap.h | 7 +++++++
    mm/readahead.c | 6 +-----
    2 files changed, 8 insertions(+), 5 deletions(-)

    diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
    index 8455a3e16900..77c20da5ae99 100644
    --- a/include/linux/pagemap.h
    +++ b/include/linux/pagemap.h
    @@ -759,6 +759,13 @@ struct readahead_control {
    unsigned int _batch_count;
    };

    +#define DEFINE_READAHEAD(rac, f, m, i) \
    + struct readahead_control rac = { \
    + .file = f, \
    + .mapping = m, \
    + ._index = i, \
    + }
    +
    /**
    * readahead_page - Get the next page to read.
    * @rac: The current readahead request.
    diff --git a/mm/readahead.c b/mm/readahead.c
    index 3c9a8dd7c56c..2126a2754e22 100644
    --- a/mm/readahead.c
    +++ b/mm/readahead.c
    @@ -179,11 +179,7 @@ void page_cache_readahead_unbounded(struct address_space *mapping,
    {
    LIST_HEAD(page_pool);
    gfp_t gfp_mask = readahead_gfp_mask(mapping);
    - struct readahead_control rac = {
    - .mapping = mapping,
    - .file = file,
    - ._index = index,
    - };
    + DEFINE_READAHEAD(rac, file, mapping, index);
    unsigned long i;

    /*
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-06-10 22:14    [W:4.432 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site