Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 10 Jun 2020 21:18:19 +0200 | Subject | Re: [PATCH 1/2] dt-bindings: spi: renesas,sh-msiof: Add r8a7742 support |
| |
Hi Mark,
On Wed, Jun 10, 2020 at 6:49 PM Mark Brown <broonie@kernel.org> wrote: > On Wed, Jun 10, 2020 at 01:59:24PM +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 10, 2020 at 1:08 PM Mark Brown <broonie@kernel.org> wrote: > > > To repeat my previous feedback I'd expect a driver update as well. > > > No driver update is needed. > > > Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml says: > > I'm much more comfortable explicitly listing the new compatible so that > even if someone makes a DT that doesn't bother listing the fallbacks > things will work.
Adding all of them would cause even more churn when adding support for a new SoC... There are already more than 700 "renesas," compatible values documented that are not directly matched by drivers. Nowadays we have "make dtbs_check", so if a DTS doesn't conform to the binding, it will be flagged.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |