Messages in this thread | | | Subject | Re: [PATCH 3/7] reset: add BCM6345 reset controller driver | From | Álvaro Fernández Rojas <> | Date | Wed, 10 Jun 2020 08:08:37 +0200 |
| |
Hi Florian,
> El 9 jun 2020, a las 22:17, Florian Fainelli <f.fainelli@gmail.com> escribió: > > > > On 6/9/2020 9:41 AM, Álvaro Fernández Rojas wrote: >>>>> If you can do without this, with I think this driver could be made to >>>>> use reset-simple. >>>> >>>> Yes, but only if I can add reset support with a configurable sleep range to reset-simple. Is this possible? >>> >>> I should have mentioned, support for this is on the reset/next branch: >>> >>> git://git.pengutronix.de/pza/linux.git reset/next >> >> Yes, but reset_us was only added to reset_simple_data, so there’s no way to fill that value from reset_simple_devdata or device tree, right? > > Not that I can see, but you could certainly extend it here: > > if (devdata) { > reg_offset = devdata->reg_offset; > if (devdata->nr_resets) > data->rcdev.nr_resets = devdata->nr_resets; > data->active_low = devdata->active_low; > data->status_active_low = devdata->status_active_low; > }
Yes, I would extend it there too, but I was just saying that it’s a bit strange that it was only added to reset_simple_data without any way to fill the value.
> > and have an appropriate devdata structure be provided for your > compatible string: > > + { .compatible = "brcm,bcm6345-reset", .data = bcm6345_reset_devdata }, > -- > Florian
Regards, Álvaro.
| |