Messages in this thread | | | Subject | Re: [PATCH] .clang-format: update column limit | From | Joe Perches <> | Date | Wed, 10 Jun 2020 10:13:24 -0700 |
| |
On Wed, 2020-06-10 at 14:51 +0200, Christian Brauner wrote: > The provided clang-format file wraps at 80 chars. If noone minds I'd like > to adjust this limit to 100 similar to what checkpatch (cf. [1]) uses now. > > [1]: commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> [] > diff --git a/.clang-format b/.clang-format [] > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 > BreakAfterJavaFieldAnnotations: false > BreakStringLiterals: false > -ColumnLimit: 80 > +ColumnLimit: 100
Ii think this is a not a good change.
If you read the commit log you provided, it ways "staying withing 80 columns is certainly still _preferred_"
With this change, clang would _always_ wrap to 100 columns.
clang would not make any reasonable attempt to use 80 when it should.
| |