| Subject | Re: [PATCH v2 2/6] soc: bcm: add BCM63xx power domain driver | From | Florian Fainelli <> | Date | Wed, 10 Jun 2020 09:49:14 -0700 |
| |
On 6/10/2020 9:32 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Thanks for addressing the previous comments, this looks good to me, there is just a single request below:
[snip]
> +static const struct bcm63xx_power_data bcm6318_power_domains[] = { > + { > + .name = "pcie", > + .bit = 0,
All of these bits definition should use the constants that you add in patches 3 through 6, this means you would have to re-order the patches to maintain bisectability obviously.
Thanks! -- Florian
|