lkml.org 
[lkml]   [2020]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator
From
Date
Hi Pi-Hsun,

Thank you for your patch. Some few/trivial comments below

On 10/6/20 11:07, Pi-Hsun Shih wrote:
> Add DT binding documentation for cros-ec-regulator, a voltage regulator
> controlled by ChromeOS EC.
>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
> Changes from v2:
> * No change
>
> Changes from v1:
> * Change compatible string to google,regulator-cros-ec.
> * Use reg property in device tree.
> * Change license for dt binding according to checkpatch.pl.
> ---
> .../bindings/regulator/cros-ec-regulator.yaml | 43 +++++++++++++++++++


The vendor should be part of the binding name, google,cros-ec-regulator.yaml

> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/cros-ec-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/cros-ec-regulator.yaml b/Documentation/devicetree/bindings/regulator/cros-ec-regulator.yaml
> new file mode 100644
> index 000000000000..e677614dcdf9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/cros-ec-regulator.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/cros-ec-regulator.yaml#

Remember also to change the name here.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ChromeOS EC controlled voltage regulators
> +
> +maintainers:
> + - Pi-Hsun Shih <pihsun@chromium.org>
> +
> +description:
> + Any property defined as part of the core regulator binding, defined in
> + regulator.yaml, can also be used.
> +
> +allOf:
> + - $ref: "regulator.yaml#"
> +
> +properties:
> + compatible:
> + const: google,regulator-cros-ec
> +
> + reg:
> + maxItems: 1
> + description: Identifier for the voltage regulator to ChromeOS EC.
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |

Please use a full example,

spi0 {
#address-cells = <1>;
#size-cells = <0>;

cros_ec: ec@0 {
compatible = "google,cros-ec-spi";
reg = <0>;


> + cros-ec {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + regulator@0 {
> + compatible = "regulator-cros-ec";

The compatible should be "google,cros-ec-regulator"

> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + reg = <0>;
> + };
> + };
> +...
>

\
 
 \ /
  Last update: 2020-06-10 18:25    [W:0.061 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site