lkml.org 
[lkml]   [2020]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 0/3] serial: core: fix up sysrq regressions
    On Wed, Jun 10, 2020 at 05:22:29PM +0200, Johan Hovold wrote:
    > This series fixes a few regressions introduced by the recent sysrq
    > rework that went into 5.6.
    >
    > The fix for the unnecessary per-character overhead probably could have
    > been marked for stable but I left that decision to the maintainers as it
    > is a bit intrusive (although mostly shuffling code around).

    I see a problem, thanks for pointing out!
    The fix LGTM! FWIW,
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

    >
    > Johan
    >
    > Changes in v2
    > - inline uart_unlock_and_check_sysrq() along with the other helpers
    > (restoring the interrupt state in a helper was never an issue)
    >
    >
    > Johan Hovold (3):
    > Revert "serial: core: Refactor uart_unlock_and_check_sysrq()"
    > serial: core: fix sysrq overhead regression
    > serial: core: drop redundant sysrq checks
    >
    > drivers/tty/serial/serial_core.c | 96 +----------------------------
    > include/linux/serial_core.h | 102 +++++++++++++++++++++++++++++--
    > 2 files changed, 100 insertions(+), 98 deletions(-)
    >
    > --
    > 2.26.2
    >

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2020-06-10 18:22    [W:2.667 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site