lkml.org 
[lkml]   [2020]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kselftest: runner: fix TAP output for skipped tests
From
Date
On 6/10/20 9:44 AM, Paolo Bonzini wrote:
> According to the TAP specification, a skipped test must be marked as "ok"
> and annotated with the SKIP directive, for example
>
> ok 23 # skip Insufficient flogiston pressure.
> (https://testanything.org/tap-specification.html)
>
> Fix the runner script to match this.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tools/testing/selftests/kselftest/runner.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index 676b3a8b114d..f4815cbcd60f 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -77,7 +77,7 @@ run_one()
> echo "ok $test_num $TEST_HDR_MSG") ||
> (rc=$?; \
> if [ $rc -eq $skip_rc ]; then \
> - echo "not ok $test_num $TEST_HDR_MSG # SKIP"
> + echo "ok $test_num $TEST_HDR_MSG # SKIP"
> elif [ $rc -eq $timeout_rc ]; then \
> echo "#"
> echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
>

Thanks. I will pull this in for Linux 5.8-rc2

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-06-10 18:20    [W:0.094 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site