Messages in this thread | | | Subject | Re: [PATCH v2 1/9] dt-bindings: reset: Add a binding for the RPi Firmware reset controller | From | Nicolas Saenz Julienne <> | Date | Wed, 10 Jun 2020 17:37:15 +0200 |
| |
Hi Florian, thanks for the review :)
On Tue, 2020-06-09 at 11:07 -0700, Florian Fainelli wrote: > > On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote: > > The firmware running on the RPi VideoCore can be used to reset and > > initialize HW controlled by the firmware. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > > > > --- > > > > Changes since v1: > > - Correct cells binding as per Florian's comment > > - Change compatible string to be more generic > > > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835- > > firmware.yaml > > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835- > > firmware.yaml > > index b48ed875eb8e..23a885af3a28 100644 > > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835- > > firmware.yaml > > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835- > > firmware.yaml > > @@ -39,6 +39,22 @@ properties: > > - compatible > > - "#clock-cells" > > > > + reset: > > + type: object > > + > > + properties: > > + compatible: > > + const: raspberrypi,firmware-reset > > + > > + "#reset-cells": > > + const: 1 > > + description: > > > Is this a stray '>' character? If so, with that fixed:
No, it marks the formatting of the text below. | will keep the formatting as is, > will leave the formatting to whatever is going to use it.
Regards, Nicolas
[unhandled content-type:application/pgp-signature] | |