Messages in this thread | | | Date | Wed, 10 Jun 2020 12:18:19 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] EDAC, {skx, i10nm}: Advice mcelog that the error were handled |
| |
On 10.06.20 14:58:01, Zhenzhong Duan wrote: > If one MCE error has been processed in kernel, it's not necessory > to pass it to user level mcelog. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Reviewed-by: Robert Richter <rrichter@marvell.com>
> --- > drivers/edac/skx_common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c > index 46be1a7..8c0165b 100644 > --- a/drivers/edac/skx_common.c > +++ b/drivers/edac/skx_common.c > @@ -615,7 +615,8 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val, > > skx_mce_output_error(mci, mce, &res); > > - return NOTIFY_DONE; > + /* Advice mcelog that the error were handled */
... error was ...
And make a sentence out of it, so close with a dot.
> + return NOTIFY_STOP;
This change aligns with other implementation in:
i7core_mce_check_error(), amd_decode_mce() and sbridge_mce_check_error().
-Robert
> } > > void skx_remove(void) > -- > 1.8.3.1 >
| |