Messages in this thread Patch in this message | | | From | Valentin Schneider <> | Subject | Re: [PATCH] sched: correct SD_flags returned by tl->sd_flags() | Date | Wed, 10 Jun 2020 11:03:14 +0100 |
| |
On 09/06/20 16:09, Peng Liu wrote: > During sched domain init, we check whether non-topological SD_flags are > returned by tl->sd_flags(), if found, fire a waning and correct the ^^^^^^ s/waning/warning/
> violation, but the code failed to correct the violation. Correct this. > > Fixes: 143e1e28cb40 ("sched: Rework sched_domain topology definition") > Signed-off-by: Peng Liu <iwtbavbm@gmail.com>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
> --- > kernel/sched/topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index ba81187bb7af..9079d865a935 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -1328,7 +1328,7 @@ sd_init(struct sched_domain_topology_level *tl, > sd_flags = (*tl->sd_flags)(); > if (WARN_ONCE(sd_flags & ~TOPOLOGY_SD_FLAGS, > "wrong sd_flags in topology description\n")) > - sd_flags &= ~TOPOLOGY_SD_FLAGS; > + sd_flags &= TOPOLOGY_SD_FLAGS; > > /* Apply detected topology flags */ > sd_flags |= dflags;
| |