Messages in this thread | | | From | Ard Biesheuvel <> | Date | Wed, 10 Jun 2020 10:00:19 +0200 | Subject | Re: [PATCH v2 1/2] efi/libstub/arm64: link stub lib.a conditionally |
| |
On Wed, 10 Jun 2020 at 09:58, Will Deacon <will@kernel.org> wrote: > > On Thu, Jun 04, 2020 at 11:20:30AM +0900, Masahiro Yamada wrote: > > Since commit 799c43415442 ("kbuild: thin archives make default for > > all archs"), core-y is passed to the linker with --whole-archive. > > Hence, the whole of stub library is linked to vmlinux. > > > > Use libs-y so that lib.a is passed after --no-whole-archive for > > conditional linking. > > > > The unused drivers/firmware/efi/libstub/relocate.o will be dropped > > for ARCH=arm64. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > --- > > > > This patch touches under arch/arm64/, but > > this is more related to efi. > > I am sending this to Ard. > > Ok, I'll ignore this then. Ard -- please yell if you want me to do anything > else with it. >
I am going to send a batch of EFI fixes early next week, so I can take this as well, or alternatively, you can apply it directly.
> > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > > index 650e1185c190..48a6afa774fc 100644 > > --- a/arch/arm64/Makefile > > +++ b/arch/arm64/Makefile > > @@ -145,7 +145,7 @@ export TEXT_OFFSET > > > > core-y += arch/arm64/ > > libs-y := arch/arm64/lib/ $(libs-y) > > -core-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a > > +libs-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a > > > > # Default target when executing plain make > > boot := arch/arm64/boot > > -- > > 2.25.1 > >
| |