lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 059/142] cifs: Fix null pointer check in cifs_read
    Date
    From: Steve French <stfrench@microsoft.com>

    [ Upstream commit 9bd21d4b1a767c3abebec203342f3820dcb84662 ]

    Coverity scan noted a redundant null check

    Coverity-id: 728517
    Reported-by: Coverity <scan-admin@coverity.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Reviewed-by: Shyam Prasad N <nspmangalore@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/file.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/file.c b/fs/cifs/file.c
    index b095094c0842..4959dbe740f7 100644
    --- a/fs/cifs/file.c
    +++ b/fs/cifs/file.c
    @@ -3997,7 +3997,7 @@ cifs_read(struct file *file, char *read_data, size_t read_size, loff_t *offset)
    * than it negotiated since it will refuse the read
    * then.
    */
    - if ((tcon->ses) && !(tcon->ses->capabilities &
    + if (!(tcon->ses->capabilities &
    tcon->ses->server->vals->cap_large_files)) {
    current_read_size = min_t(uint,
    current_read_size, CIFSMaxBufSize);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:10    [W:2.757 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site