lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 083/142] mmc: block: Fix use-after-free issue for rpmb
    Date
    From: Peng Hao <richard.peng@oppo.com>

    [ Upstream commit 202500d21654874aa03243e91f96de153ec61860 ]

    The data structure member “rpmb->md” was passed to a call of the function
    “mmc_blk_put” after a call of the function “put_device”. Reorder these
    function calls to keep the data accesses consistent.

    Fixes: 1c87f7357849 ("mmc: block: Fix bug when removing RPMB chardev ")
    Signed-off-by: Peng Hao <richard.peng@oppo.com>
    Cc: stable@vger.kernel.org
    [Uffe: Fixed up mangled patch and updated commit message]
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/core/block.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
    index 9d01b5dca519..7f480c6b1981 100644
    --- a/drivers/mmc/core/block.c
    +++ b/drivers/mmc/core/block.c
    @@ -2475,8 +2475,8 @@ static int mmc_rpmb_chrdev_release(struct inode *inode, struct file *filp)
    struct mmc_rpmb_data *rpmb = container_of(inode->i_cdev,
    struct mmc_rpmb_data, chrdev);

    - put_device(&rpmb->dev);
    mmc_blk_put(rpmb->md);
    + put_device(&rpmb->dev);

    return 0;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:09    [W:4.521 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site