lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 49/77] fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
    Date
    From: Alexander Potapenko <glider@google.com>

    [ Upstream commit 1d605416fb7175e1adf094251466caa52093b413 ]

    KMSAN reported uninitialized data being written to disk when dumping
    core. As a result, several kilobytes of kmalloc memory may be written
    to the core file and then read by a non-privileged user.

    Reported-by: sam <sunhaoyl@outlook.com>
    Signed-off-by: Alexander Potapenko <glider@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Acked-by: Kees Cook <keescook@chromium.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com
    Link: https://github.com/google/kmsan/issues/76
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/binfmt_elf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
    index 166846a40078..2c433c95adb5 100644
    --- a/fs/binfmt_elf.c
    +++ b/fs/binfmt_elf.c
    @@ -1740,7 +1740,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
    (!regset->active || regset->active(t->task, regset) > 0)) {
    int ret;
    size_t size = regset->n * regset->size;
    - void *data = kmalloc(size, GFP_KERNEL);
    + void *data = kzalloc(size, GFP_KERNEL);
    if (unlikely(!data))
    return 0;
    ret = regset->get(t->task, regset,
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:02    [W:4.258 / U:0.932 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site