Messages in this thread | | | Date | Mon, 1 Jun 2020 15:09:05 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 13/14] perf tests: Add parse metric test for ipc metric |
| |
On Mon, Jun 01, 2020 at 12:55:44AM -0700, Ian Rogers wrote: > On Sun, May 24, 2020 at 3:43 PM Jiri Olsa <jolsa@kernel.org> wrote: > > > > Adding new test that process metrics code and checks > > the expected results. Starting with easy ipc metric. > > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > Acked-by: Ian Rogers <irogers@google.com> > > I wonder if there's a better organization with testing in > pmu-events.c, expr.c and now parse-metric.c.
hum, so - expr.c is testing core interface, - parse-metric is testing specific metric processing from parsing to final ratio - pmu-events.c is testing pmu events aliases and parsing of all the metrics
pmu-events.c is testing both pmu events and metrics, but I think it fits in the way it's done together
jirka
| |