Messages in this thread | | | Subject | Re: [PATCH V6 4/5] clk: qcom: Add ipq6018 apss clock controller | From | Sivaprakash Murugesan <> | Date | Mon, 1 Jun 2020 18:11:15 +0530 |
| |
Hi Stepen,
On 5/28/2020 7:29 AM, Stephen Boyd wrote: > Quoting Sivaprakash Murugesan (2020-05-27 05:24:51) >> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c >> new file mode 100644 >> index 0000000..004f7e1 >> --- /dev/null >> +++ b/drivers/clk/qcom/apss-ipq6018.c >> @@ -0,0 +1,106 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) 2018, The Linux Foundation. All rights reserved. >> + */ >> + >> +#include <linux/kernel.h> >> +#include <linux/err.h> >> +#include <linux/platform_device.h> >> +#include <linux/clk-provider.h> >> +#include <linux/regmap.h> >> +#include <linux/module.h> >> + >> +#include <dt-bindings/clock/qcom,apss-ipq.h> >> + >> +#include "common.h" >> +#include "clk-regmap.h" >> +#include "clk-branch.h" >> +#include "clk-alpha-pll.h" >> +#include "clk-regmap-mux.h" >> + >> +enum { >> + P_XO, >> + P_APSS_PLL_EARLY, >> +}; >> + >> +static const struct clk_parent_data parents_apcs_alias0_clk_src[] = { >> + { .fw_name = "xo" }, >> + { .fw_name = "pll" }, > This pll clk is not described in the binding. Please add it there.
Sorry I did not get this, this PLL is not directly defined in this driver and it comes
from dts. do you still want to describe it in binding?
| |