Messages in this thread | | | Subject | Re: [PATCH] iommu: Improve exception handling in iommu_group_alloc() | From | Markus Elfring <> | Date | Mon, 1 Jun 2020 14:38:05 +0200 |
| |
> Optimize the error handling to free the resources correctly when > failed to allocate an iommu group.
* I would not categorise the desired completion of exception handling as a software optimisation.
* Would you like to add the tag “Fixes” to the commit message?
* I suggest to avoid the specification of duplicate function calls. Will it be helpful to add a few jump targets? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
Regards, Markus
| |