lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] afs: Fix memory leak in afs_put_sysnames()
Date
Markus Elfring <Markus.Elfring@web.de> wrote:

> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
>
> * I suggest to use the wording “reference counter”.

Can you use ASCII quotes please? Not all fonts contain these quotes, and
occasionally they got copied into commit messages.

> * Where did you notice a “memory leak” here?

He said "sysnames should be freed after refcnt being decreased to zero in
afs_put_sysnames()".

> * Will the tag “Fixes” become relevant for the commit message?

It is the correct tag.

David

\
 
 \ /
  Last update: 2020-06-01 14:37    [W:0.172 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site