Messages in this thread | | | Subject | Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries | From | Markus Elfring <> | Date | Mon, 1 Jun 2020 14:00:48 +0200 |
| |
> Fix some potential memory leaks in error handling branches while > iterating xattr entries.
Such information is useful.
> For example, function ubifs_tnc_remove_ino() > forgets to free pxent if it exists. Similar problems also exist in > ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().
Can an other wording variant be a bit nicer?
I suggest to avoid the specification of duplicate function calls (also for the desired exception handling). Will it be helpful to add a few jump targets? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
Regards, Markus
| |