Messages in this thread | | | Subject | Re: [PATCH] afs: Fix memory leak in afs_put_sysnames() | From | Markus Elfring <> | Date | Mon, 1 Jun 2020 13:18:18 +0200 |
| |
> sysnames should be freed after refcnt being decreased to zero in > afs_put_sysnames().
* I suggest to use the wording “reference counter”.
* Where did you notice a “memory leak” here?
> Besides, it would be better set net->sysnames > to 'NULL' after net->sysnames being released if afs_put_sysnames() > aims on an afs_sysnames object.
* Would you like to consider an adjustment for this information?
* How do you think about to add an imperative wording?
* Will the tag “Fixes” become relevant for the commit message?
Regards, Markus
| |