lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] afs: Fix memory leak in afs_put_sysnames()
From
Date
> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().

* I suggest to use the wording “reference counter”.

* Where did you notice a “memory leak” here?


> Besides, it would be better set net->sysnames
> to 'NULL' after net->sysnames being released if afs_put_sysnames()
> aims on an afs_sysnames object.

* Would you like to consider an adjustment for this information?

* How do you think about to add an imperative wording?

* Will the tag “Fixes” become relevant for the commit message?

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-01 13:19    [W:0.034 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site