lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change
On 29-05-20, 17:00, Sibi Sankar wrote:
> > > +static int qcom_cpufreq_update_opp(struct device *cpu_dev,
> > > + unsigned long freq_khz,
> > > + unsigned long volt)
> > > +{
> > > + unsigned long freq_hz = freq_khz * 1000;
> > > +
> > > + if (dev_pm_opp_adjust_voltage(cpu_dev, freq_hz, volt, volt, volt))
> > > + return dev_pm_opp_add(cpu_dev, freq_hz, volt);
> >
> > What's going on here ? Why add OPP here ?
>
> We update the voltage if opp were
> initially added as part of
> dev_pm_opp_of_add_table. However
> if the cpu node does not have an
> opp table associated with it, we
> do a opp_add_v1 instead.

Instead of depending on the failure of dev_pm_opp_adjust_voltage(),
pass a flag to qcom_cpufreq_update_opp() which will decide if we want
to adjust voltage or add an opp.

--
viresh

\
 
 \ /
  Last update: 2020-06-01 13:02    [W:0.125 / U:3.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site