lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip: sched/core] smp: Move irq_work_run() out of flush_smp_call_function_queue()
    The following commit has been merged into the sched/core branch of tip:

    Commit-ID: afaa653c564da38c0b34c4baba31e88c46a8764c
    Gitweb: https://git.kernel.org/tip/afaa653c564da38c0b34c4baba31e88c46a8764c
    Author: Peter Zijlstra <peterz@infradead.org>
    AuthorDate: Tue, 26 May 2020 18:11:00 +02:00
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitterDate: Thu, 28 May 2020 10:54:15 +02:00

    smp: Move irq_work_run() out of flush_smp_call_function_queue()

    This ensures flush_smp_call_function_queue() is strictly about
    call_single_queue.

    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Link: https://lore.kernel.org/r/20200526161907.895109676@infradead.org
    ---
    kernel/smp.c | 17 +++++++++--------
    1 file changed, 9 insertions(+), 8 deletions(-)

    diff --git a/kernel/smp.c b/kernel/smp.c
    index db2f738..f720e38 100644
    --- a/kernel/smp.c
    +++ b/kernel/smp.c
    @@ -84,6 +84,7 @@ int smpcfd_dying_cpu(unsigned int cpu)
    * still pending.
    */
    flush_smp_call_function_queue(false);
    + irq_work_run();
    return 0;
    }

    @@ -191,6 +192,14 @@ static int generic_exec_single(int cpu, call_single_data_t *csd,
    void generic_smp_call_function_single_interrupt(void)
    {
    flush_smp_call_function_queue(true);
    +
    + /*
    + * Handle irq works queued remotely by irq_work_queue_on().
    + * Smp functions above are typically synchronous so they
    + * better run first since some other CPUs may be busy waiting
    + * for them.
    + */
    + irq_work_run();
    }

    /**
    @@ -267,14 +276,6 @@ static void flush_smp_call_function_queue(bool warn_cpu_offline)
    csd_unlock(csd);
    func(info);
    }
    -
    - /*
    - * Handle irq works queued remotely by irq_work_queue_on().
    - * Smp functions above are typically synchronous so they
    - * better run first since some other CPUs may be busy waiting
    - * for them.
    - */
    - irq_work_run();
    }

    /*
    \
     
     \ /
      Last update: 2020-06-01 11:53    [W:2.604 / U:21.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site