Messages in this thread | | | Subject | Re: [PATCH] KVM: Use previously computed array_size() | From | Paolo Bonzini <> | Date | Mon, 1 Jun 2020 10:46:47 +0200 |
| |
On 30/05/20 19:28, Denis Efremov wrote: >> On Sat, 2020-05-30 at 17:35 +0300, Denis Efremov wrote: >>> array_size() is used in alloc calls to compute the allocation >>> size. Next, "raw" multiplication is used to compute the size >>> for copy_from_user(). The patch removes duplicated computation >>> by saving the size in a var. No security concerns, just a small >>> optimization. >>> >>> Signed-off-by: Denis Efremov <efremov@linux.com> >> Perhaps use vmemdup_user? > vmemdup_user() uses kvmalloc internally. I think it will also require > changing vfree to kvfree. >
Yes, it would be a good idea.
Paolo
| |