lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/4] workqueue: use BUILD_BUG_ON() for compile time test instead of WARN_ON()
    Date
    Any runtime WARN_ON() has to be fixed, and BUILD_BUG_ON() can
    help you nitice it earlier.

    Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
    ---
    kernel/workqueue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/workqueue.c b/kernel/workqueue.c
    index 7a1fc9fe6314..35120b909234 100644
    --- a/kernel/workqueue.c
    +++ b/kernel/workqueue.c
    @@ -5905,7 +5905,7 @@ void __init workqueue_init_early(void)
    int hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ;
    int i, cpu;

    - WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));
    + BUILD_BUG_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));

    BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL));
    cpumask_copy(wq_unbound_cpumask, housekeeping_cpumask(hk_flags));
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-06-01 10:47    [W:3.689 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site