lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iommu: Improve exception handling in iommu_group_alloc()
On Mon, Jun 01, 2020 at 02:38:05PM +0200, Markus Elfring wrote:
> > Optimize the error handling to free the resources correctly when
> > failed to allocate an iommu group.
>
> * I would not categorise the desired completion of exception handling
> as a software optimisation.
>
> * Would you like to add the tag “Fixes” to the commit message?

Sure.

>
> * I suggest to avoid the specification of duplicate function calls.
> Will it be helpful to add a few jump targets?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455

I don't think it is helpful or readable to add some jump targets here, since the exception handling is very simple here.

\
 
 \ /
  Last update: 2020-06-02 03:51    [W:0.093 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site