lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v5] hinic: add set_channels ethtool_ops support
From
Date
On 2020/6/2 1:53, David Miller wrote:
> From: Luo bin <luobin9@huawei.com>
> Date: Mon, 1 Jun 2020 18:57:48 +0800
>
>> @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>> struct hinic_txq *txq;
>> struct hinic_qp *qp;
>>
>> + if (unlikely(!netif_carrier_ok(netdev))) {
>> + dev_kfree_skb_any(skb);
>> + return NETDEV_TX_OK;
>> + }
> As stated by another reviewer, this change is unrelated to adding
> set_channels support. Please remove it from this patch.
Will fix. Thanks.
> .

\
 
 \ /
  Last update: 2020-06-02 02:32    [W:0.057 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site