Messages in this thread | | | Subject | Re: [PATCH] soundwire: clarify SPDX use of GPL-2.0 | From | Pierre-Louis Bossart <> | Date | Mon, 1 Jun 2020 15:50:13 -0500 |
| |
On 6/1/20 12:38 AM, Greg KH wrote: > On Mon, Jun 01, 2020 at 01:28:07AM +0800, Bard Liao wrote: >> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> >> >> Change SPDX from GPL-2.0 to GPL-2.0-only for Intel-contributed >> code. This was explicit before the transition to SPDX and lost in >> translation. > > It is also explicit in the "GPL-2.0" lines as well, did you read the > LICENSES/preferred/GPL-2.0 file for the allowed tags to be used for this > license? > > So this doesn't change anything, and we are trying to cut down on this > type of churn until, maybe, after the whole kernel has proper SPDX > lines.
My commit message was misleading, sorry. For SoundWire, we recently added new files with GPL-2.0-only (master + sysfs), as recommended since the short GPL-2.0 identifier is deprecated (https://spdx.org/licenses/GPL-2.0.html https://spdx.org/licenses/).
Intel does not mind if we delay this change, you are right that this doesn't change anything license-wise. I just felt it was a good time to align old and new contributions to avoid having half of the files with GPL-2.0 and half with GPL-2.0-only.
We still have quite a few patches for SoundWire (~80 coming w/ 7k lines changed), so those changes are really minimal in comparison with the actual 'churn' to fix programming sequences, power management, multi-link management and bit allocation.
Oh and this was not intended to be added to 5.8 btw or pulled as a fix, really nothing to do with the merge window.
If you prefer us to keep this change on the back burner, that's fine, the only intent was to keep all SoundWire-related files consistent.
| |