lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 24/48] iommu: Fix reference count leak in iommu_group_alloc.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 7cc31613734c4870ae32f5265d576ef296621343 ]

    kobject_init_and_add() takes reference even when it fails.
    Thus, when kobject_init_and_add() returns an error,
    kobject_put() must be called to properly clean up the kobject.

    Fixes: d72e31c93746 ("iommu: IOMMU Groups")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Link: https://lore.kernel.org/r/20200527210020.6522-1-wu000273@umn.edu
    Signed-off-by: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iommu/iommu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iommu/iommu.c
    +++ b/drivers/iommu/iommu.c
    @@ -206,7 +206,7 @@ again:
    mutex_lock(&iommu_group_mutex);
    ida_remove(&iommu_group_ida, group->id);
    mutex_unlock(&iommu_group_mutex);
    - kfree(group);
    + kobject_put(&group->kobj);
    return ERR_PTR(ret);
    }


    \
     
     \ /
      Last update: 2020-06-01 21:01    [W:3.252 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site