lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 08/95] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()
    Date
    From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

    [ Upstream commit d28ea1fbbf437054ef339afec241019f2c4e2bb6 ]

    Once the traversal of the list is completed with list_for_each_entry(),
    the iterator (node) will point to an invalid object. So passing this to
    qrtr_local_enqueue() which is outside of the iterator block is erroneous
    eventhough the object is not used.

    So fix this by passing NULL to qrtr_local_enqueue().

    Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
    Reported-by: kbuild test robot <lkp@intel.com>
    Reported-by: Julia Lawall <julia.lawall@lip6.fr>
    Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/qrtr/qrtr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/qrtr/qrtr.c
    +++ b/net/qrtr/qrtr.c
    @@ -718,7 +718,7 @@ static int qrtr_bcast_enqueue(struct qrt
    }
    mutex_unlock(&qrtr_node_lock);

    - qrtr_local_enqueue(node, skb, type, from, to);
    + qrtr_local_enqueue(NULL, skb, type, from, to);

    return 0;
    }

    \
     
     \ /
      Last update: 2020-06-01 20:54    [W:4.563 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site