lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v2] afs: Fix memory leak in afs_put_sysnames()
From
Date
> Perhaps something like:
>
> Fix afs_put_sysnames() to actually free the specified afs_sysnames
> object after its reference count has been decreased to zero and its
> contents have been released.

* How do you think about to omit the word "Fix" because of the provided tag?

* Is freeing and releasing an item a duplicate operation anyhow?


>> Will it matter to mention the size of the data structure "afs_sysnames"?
>
> Why is it necessary to do so?

I suggest to express the impact of the missed function call "kfree".

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-01 20:52    [W:0.073 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site