Messages in this thread | | | Subject | Re: [v2] afs: Fix memory leak in afs_put_sysnames() | From | Markus Elfring <> | Date | Mon, 1 Jun 2020 20:04:50 +0200 |
| |
> Perhaps something like: > > Fix afs_put_sysnames() to actually free the specified afs_sysnames > object after its reference count has been decreased to zero and its > contents have been released.
* How do you think about to omit the word "Fix" because of the provided tag?
* Is freeing and releasing an item a duplicate operation anyhow?
>> Will it matter to mention the size of the data structure "afs_sysnames"? > > Why is it necessary to do so?
I suggest to express the impact of the missed function call "kfree".
Regards, Markus
| |