lkml.org 
[lkml]   [2020]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 078/142] gpu/drm: Ingenic: Fix opaque pointer casted to wrong type
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    [ Upstream commit abf56fadf0e208abfb13ad1ac0094416058da0ad ]

    The opaque pointer passed to the IRQ handler is a pointer to the
    drm_device, not a pointer to our ingenic_drm structure.

    It still worked, because our ingenic_drm structure contains the
    drm_device as its first field, so the pointer received had the same
    value, but this was not semantically correct.

    Cc: stable@vger.kernel.org # v5.3
    Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs")
    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200516215057.392609-5-paul@crapouillou.net
    Acked-by: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
    index 9e95f6fd5406..376fca6ca9f4 100644
    --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
    +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
    @@ -467,7 +467,7 @@ static int ingenic_drm_encoder_atomic_check(struct drm_encoder *encoder,

    static irqreturn_t ingenic_drm_irq_handler(int irq, void *arg)
    {
    - struct ingenic_drm *priv = arg;
    + struct ingenic_drm *priv = drm_device_get_priv(arg);
    unsigned int state;

    regmap_read(priv->map, JZ_REG_LCD_STATE, &state);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-01 20:46    [W:4.344 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site