lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/15] qed: use new module_firmware_crashed()
    Date
    This makes use of the new module_firmware_crashed() to help
    annotate when firmware for device drivers crash. When firmware
    crashes devices can sometimes become unresponsive, and recovery
    sometimes requires a driver unload / reload and in the worst cases
    a reboot.

    Using a taint flag allows us to annotate when this happens clearly.

    Cc: Ariel Elior <aelior@marvell.com>
    Cc: GR-everest-linux-l2@marvell.com
    Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
    index f4eebaabb6d0..9cc6287b889b 100644
    --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
    @@ -7854,6 +7854,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer)
    REGDUMP_HEADER_SIZE,
    &feature_size);
    if (!rc) {
    + module_firmware_crashed();
    *(u32 *)((u8 *)buffer + offset) =
    qed_calc_regdump_header(cdev, PROTECTION_OVERRIDE,
    cur_engine,
    @@ -7869,6 +7870,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer)
    rc = qed_dbg_fw_asserts(cdev, (u8 *)buffer + offset +
    REGDUMP_HEADER_SIZE, &feature_size);
    if (!rc) {
    + module_firmware_crashed();
    *(u32 *)((u8 *)buffer + offset) =
    qed_calc_regdump_header(cdev, FW_ASSERTS,
    cur_engine, feature_size,
    @@ -7906,6 +7908,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void *buffer)
    rc = qed_dbg_grc(cdev, (u8 *)buffer + offset +
    REGDUMP_HEADER_SIZE, &feature_size);
    if (!rc) {
    + module_firmware_crashed();
    *(u32 *)((u8 *)buffer + offset) =
    qed_calc_regdump_header(cdev, GRC_DUMP,
    cur_engine,
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-05-09 06:37    [W:4.159 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site