Messages in this thread | | | Subject | Re: [PATCH net-next 3/4] net: phy: broadcom: add cable test support | From | Florian Fainelli <> | Date | Sat, 9 May 2020 17:09:59 -0700 |
| |
On 5/9/2020 3:37 PM, Michael Walle wrote: > Most modern broadcom PHYs support ECD (enhanced cable diagnostics). Add > support for it in the bcm-phy-lib so they can easily be used in the PHY > driver. > > There are two access methods for ECD: legacy by expansion registers and > via the new RDB registers which are exclusive. Provide functions in two > variants where the PHY driver can from. To keep things simple for now, > we just switch the register access to expansion registers in the RDB > variant for now. On the flipside, we have to keep a bus lock to prevent > any other non-legacy access on the PHY. > > Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks for dealing with the legacy expansion vs. RDB access method, this looks really nice, now I just need to test it on a variety of devices :) -- Florian
| |