Messages in this thread Patch in this message | | | From | Al Viro <> | Subject | [PATCH 02/20] fat_dir_ioctl(): hadn't needed that access_ok() for more than a decade... | Date | Sun, 10 May 2020 00:45:39 +0100 |
| |
From: Al Viro <viro@zeniv.linux.org.uk>
address is passed only to put_user() and copy_to_user()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- fs/fat/dir.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c index 054acd9fd033..b4ddf48fa444 100644 --- a/fs/fat/dir.c +++ b/fs/fat/dir.c @@ -804,8 +804,6 @@ static long fat_dir_ioctl(struct file *filp, unsigned int cmd, return fat_generic_ioctl(filp, cmd, arg); } - if (!access_ok(d1, sizeof(struct __fat_dirent[2]))) - return -EFAULT; /* * Yes, we don't need this put_user() absolutely. However old * code didn't return the right value. So, app use this value, @@ -844,8 +842,6 @@ static long fat_compat_dir_ioctl(struct file *filp, unsigned cmd, return fat_generic_ioctl(filp, cmd, (unsigned long)arg); } - if (!access_ok(d1, sizeof(struct compat_dirent[2]))) - return -EFAULT; /* * Yes, we don't need this put_user() absolutely. However old * code didn't return the right value. So, app use this value, -- 2.11.0
| |