lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net/sonic: Fix some resource leaks in error handling paths
From
Date
On Sat, 2020-05-09 at 11:13 -0700, Jakub Kicinski wrote:
> On Sat, 9 May 2020 18:47:08 +0200 Christophe JAILLET wrote:
> > Le 09/05/2020 à 03:54, Jakub Kicinski a écrit :
> > > On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > > > @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct platform_device *pdev)
> > > > struct sonic_local* lp = netdev_priv(dev);
> > > >
> > > > unregister_netdev(dev);
> > > > - dma_free_coherent(lp->device, SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> > > > - lp->descriptors, lp->descriptors_laddr);
> > > > + dma_free_coherent(lp->device,
> > > > + SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> > > > + lp->descriptors, lp->descriptors_laddr);
> > > > free_netdev(dev);
> > > >
> > > > return 0;
> > > This is a white-space only change, right? Since this is a fix we should
> > > avoid making cleanups which are not strictly necessary.
> >
> > Right.
> >
> > The reason of this clean-up is that I wanted to avoid a checkpatch
> > warning with the proposed patch and I felt that having the same layout
> > in the error handling path of the probe function and in the remove
> > function was clearer.
> > So I updated also the remove function.
>
> I understand the motivation is good.

David, maybe I missed some notification about Jakub's role.

What is Jakub's role in relation to the networking tree?


\
 
 \ /
  Last update: 2020-05-10 00:43    [W:0.090 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site