lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61
Hi Douglas

On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote:
> The BOE NV133FHM-N61 is documented in the original commit to be a
> 13.3" panel, but the size listed in our struct doesn't match.
> Specifically:
>
> math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92
>
> Searching around on the Internet shows that the size that was in the
> structure was the "Outline Size", not the "Display Area". Let's fix
> it.
>
> Also the Internet says that this panel supports 262K colors. That's
> 6bpp, not 8bpp.
>
> Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Added to drm-misc-next as I did not think this had to be updated in
mainline right now. Let me know if you expect it to land in mainline
soonish.

Sam

> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index d6c29543e510..7219436499f1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1189,10 +1189,10 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = {
> static const struct panel_desc boe_nv133fhm_n61 = {
> .modes = &boe_nv133fhm_n61_modes,
> .num_modes = 1,
> - .bpc = 8,
> + .bpc = 6,
> .size = {
> - .width = 300,
> - .height = 187,
> + .width = 294,
> + .height = 165,
> },
> .delay = {
> .hpd_absent_delay = 200,
> --
> 2.26.2.645.ge9eca65c58-goog

\
 
 \ /
  Last update: 2020-05-09 22:01    [W:0.220 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site