lkml.org 
[lkml]   [2020]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch V4 part 2 12/18] x86,objtool: Make entry_64_compat.S objtool clean
Date
Andy Lutomirski <luto@kernel.org> writes:

> On Tue, May 5, 2020 at 7:14 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>>
>> Currently entry_64_compat is exempt from objtool, but with vmlinux
>> mode there is no hiding it.
>>
>> Make the following changes to make it pass:
>>
>> - change entry_SYSENTER_compat to STT_NOTYPE; it's not a function
>> and doesn't have function type stack setup.
>>
>> - mark all STT_NOTYPE symbols with UNWIND_HINT_EMPTY; so we do
>> validate them and don't treat them as unreachable.
>>
>> - don't abuse RSP as a temp register, this confuses objtool
>> mightily as it (rightfully) thinks we're doing unspeakable
>> things to the stack.
>>
>
> Acked-by: Andy Lutomirski <luto@kernel.org>
>
>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> Did a From line get eaten?

Yes. A couple of patches which were just handed back and forth between
me and Peter lost them. Fixed them all up localy already.

Thanks,

tglx

\
 
 \ /
  Last update: 2020-05-09 12:09    [W:0.065 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site