lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 264/312] net: icmp6_send should use dst dev to determine L3 domain
    Date
    From: David Ahern <dsa@cumulusnetworks.com>

    commit 5d41ce29e3b91ef305f88d23f72b3359de329cec upstream.

    icmp6_send is called in response to some event. The skb may not have
    the device set (skb->dev is NULL), but it is expected to have a dst set.
    Update icmp6_send to use the dst on the skb to determine L3 domain.

    Fixes: ca254490c8dfd ("net: Add VRF support to IPv6 stack")
    Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/ipv6/icmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv6/icmp.c
    +++ b/net/ipv6/icmp.c
    @@ -446,7 +446,7 @@ static void icmp6_send(struct sk_buff *s
    if (__ipv6_addr_needs_scope_id(addr_type))
    iif = skb->dev->ifindex;
    else
    - iif = l3mdev_master_ifindex(skb->dev);
    + iif = l3mdev_master_ifindex(skb_dst(skb)->dev);

    /*
    * Must not send error if the source does not uniquely

    \
     
     \ /
      Last update: 2020-05-08 15:10    [W:4.499 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site